Untypical right click behavior Options

[AIM]

Steps to reproduce:

1. Use a NextGrid with "Multi Select" and "Select Full Row"

2. Select two or more rows

3. Right click a non-selected row --> this will add the right clicked row to the selection instead of un-selecting the old selection first.

[Boki (Berg)]

Hello Aim,

I think that I have fix it. If you want, I will send you a updated file.

I will need to test it a little bit more, since this area is a little bit tricky .

Best regards

[AIM]

In the meantime I also found a solution myself, but feel free to send me your solution for testing.

Here's my work around, just something to compare

Changes are made in NxCustomGrid.pas

In MouseDown change the code from:

CODE

begin
  inherited;
  Deselect := Button = mbLeft;

to:

CODE

begin
  inherited;
  Deselect := (Button = mbLeft) or (Button = mbRight); // <--- changed

In BodyMouseDown change the code from:

CODE

    { 02/29/08: If multi-select is enabled and user click on already selected cell, we will exit
                to give possibility for Drag & Drop }

    if (goMultiSelect in Options)
      and (goSelectFullRow in Options) then { multi-select? }
    begin
      if RowExist(ARow) and GetSelected(ARow) and Dragging then
      begin
        Deselect := False;
        FCanDeselect := True;
      end;
    end;

to:

CODE

    { 02/29/08: If multi-select is enabled and user click on already selected cell, we will exit
                to give possibility for Drag & Drop }

    if (goMultiSelect in Options)
      and (goSelectFullRow in Options) then { multi-select? }
    begin
      if RowExist(ARow) and GetSelected(ARow) and Dragging then
      begin
        Deselect := False;
        FCanDeselect := True;
      end;
      if RowExist(ARow) and GetSelected(ARow) and (Button = mbRight) then  // <--- new
      begin                                                                // <--- new
        Deselect := False;                                                 // <--- new
        FCanDeselect := True;                                              // <--- new
      end;                                                                 // <--- new
    end;

These changes work perfectly for me.

[Boki (Berg)]

Hello Aim,

I have slightly different solution. I was add:

CODE

    if (goMultiSelect in Options)
      and (goSelectFullRow in Options) then { multi-select? }
    begin
      if Button = mbLeft then
      begin
        if RowExist(ARow) and GetSelected(ARow) and Dragging then
        begin
          Deselect := False;
          FCanDeselect := True;
        end;
      end else if Button = mbRight then
      begin
        if not GetSelected(ARow) then
        begin
          Deselect := True;
          FCanDeselect := True;
        end;
      end;
    end;

Best regards. I hope that this work as expected too.

Best regards

[AIM]

Best regards. I hope that this work as expected too.

Yes, thank you. I'm using your solution now...

[AIM]

Boki, your solution introduced a bug.

When you right click a selection, everything is fine. If you right click an empty area, you get a crash.

The following change fixes this crash.

From:

CODE

      end else if Button = mbRight then
      begin
        if not GetSelected(ARow) then
        begin
          Deselect := True;
          FCanDeselect := True;
        end;
      end;

To:

CODE

      end else if Button = mbRight then
      begin
        if RowExist(ARow) and not GetSelected(ARow) then // ----- add: RowExist(ARow) and
        begin
          Deselect := True;
          FCanDeselect := True;
        end;
      end;

[Boki (Berg)]

Hello Aim,

I am glad that you have spot it. I have include this fix.

Best regards